Allow configuring node_config of node_pools specified in container_cluster

[drebes]

With this, node pools can be configured when defined explicitly in the google_container_cluster resource:

resource "google_container_cluster" "cluster-1" {
  name = "cluster-1"
  zone = "us-central1-a"

  additional_zones = [
    "us-central1-b",
    "us-central1-c",
  ]

  node_pool {
    name               = "frontend"
    initial_node_count = 1

    node_config {
      machine_type    = "n1-standard-1"
      disk_size_gb    = 10
    }
  }
}

Acceptance tests:

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withNodePool'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withNodePool -timeout 120m
=== RUN   TestAccContainerCluster_withNodePoolBasic
--- PASS: TestAccContainerCluster_withNodePoolBasic (272.71s)
=== RUN   TestAccContainerCluster_withNodePoolNamePrefix
--- PASS: TestAccContainerCluster_withNodePoolNamePrefix (258.92s)
=== RUN   TestAccContainerCluster_withNodePoolMultiple
--- PASS: TestAccContainerCluster_withNodePoolMultiple (270.73s)
=== RUN   TestAccContainerCluster_withNodePoolConflictingNameFields
--- PASS: TestAccContainerCluster_withNodePoolConflictingNameFields (0.02s)
=== RUN   TestAccContainerCluster_withNodePoolNodeConfig
--- PASS: TestAccContainerCluster_withNodePoolNodeConfig (290.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	1092.914s

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withNodeConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withNodeConfig -timeout 120m
=== RUN   TestAccContainerCluster_withNodeConfig
--- PASS: TestAccContainerCluster_withNodeConfig (323.94s)
=== RUN   TestAccContainerCluster_withNodeConfigScopeAlias
--- PASS: TestAccContainerCluster_withNodeConfigScopeAlias (300.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	624.152s

I've also changed google_container_node_pool to use the same node_config parsing:

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerNodePool_withNodeConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerNodePool_withNodeConfig -timeout 120m
=== RUN   TestAccContainerNodePool_withNodeConfig
--- PASS: TestAccContainerNodePool_withNodeConfig (522.87s)
=== RUN   TestAccContainerNodePool_withNodeConfigScopeAlias
--- PASS: TestAccContainerNodePool_withNodeConfigScopeAlias (540.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	1062.994s

[danawillow]

$ make testacc TEST=./google TESTARGS='-run=TestAccContainerCluster_withNodePoolNodeConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withNodePoolNodeConfig -timeout 120m
=== RUN   TestAccContainerCluster_withNodePoolNodeConfig
--- PASS: TestAccContainerCluster_withNodePoolNodeConfig (305.71s)
PASS

[danawillow]

Can you call this expandNodeConfig to match this sort of function in other resources?

[danawillow]

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!