Add support for setting labels to compute_image #339
Conversation
| @@ -229,6 +229,23 @@ func linkDiffSuppress(k, old, new string, d *schema.ResourceData) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // expandLabels pulls the value of "labels" out of a schema.ResourceData as a map[string]string. | |||
| func expandLabels(d *schema.ResourceData) map[string]string { | |||
There was a problem hiding this comment.
we use the naming convention expand* when converting from []interface{} or the ResourceData to the go client object.
For example:
func expandAliasIpRanges(ranges []interface{}) []*computeBeta.AliasIpRange
I find it a bit confusing to reuse the same term for something different.
There was a problem hiding this comment.
You mean because it's not returning a go client object? Or because the first parameter type should be of type []interface{}?
This function is indeed converting data from ResourceData but its not directly returning a go-client object (as the type of the Labels attribute is map[string]string). Not using direct go-client objects here lets us reuse this function across other apis.
There was a problem hiding this comment.
Gotcha. I assumed that a compute.Labels or something along the line existed. Nevermind my comment then.
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.