Support IAM roles on BigQuery datasets

[rolandkool]

To fix #3206

[danawillow]

Holding off review until the questions in #3206 are resolved.

[danawillow]

All right, questions have been resolved. The docs could use updating too, though, since they still say that only the primitive roles are accepted: https://github.com/terraform-providers/terraform-provider-google/blob/master/website/docs/r/bigquery_dataset.html.markdown#L113.

Because the API swaps out roles like roles/bigquery.dataOwner for their primitive counterparts (OWNER), I'd either mention something like this in the docs (to discourage people from using the predefined ones with a primitive equivalent), or add a DiffSuppressFunc that ignores diffs in those cases.

[hanfi]

hi @rolandkool
i updated the documentation on your fork :+1

https://github.com/rolandkool/terraform-provider-google/pull/1/files

[rolandkool]

hi @rolandkool
i updated the documentation on your fork :+1

https://github.com/rolandkool/terraform-provider-google/pull/1/files

@hanfi, thanks! I've fixed one small typo and merged it. Hope this can make it into the next release.

[danawillow]

Looks good, thanks! I updated the docs just a bit.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!