Update google_compute_target_pool to no longer have a plan/apply loop with instance URLs
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
suggested changes
Nov 3, 2017
| oldParts := strings.Split(old, "/") | ||
|
|
||
| // instances can also be specified in the config as a URL | ||
| r := regexp.MustCompile(fmt.Sprintf(zonalLinkBasePattern, "instances")) |
There was a problem hiding this comment.
Ideally we'd compile this to a global variable, not on every DiffSuppressFunc call.
|
|
||
| // instances can also be specified in the config as a URL | ||
| r := regexp.MustCompile(fmt.Sprintf(zonalLinkBasePattern, "instances")) | ||
| if parts := r.FindStringSubmatch(new); parts != nil { |
There was a problem hiding this comment.
Let's check that parts has enough entries to avoid panics on invalid inputs.
There was a problem hiding this comment.
Done, also made some variables hopefully to make it a bit clearer what's going on
paddycarver
approved these changes
Nov 3, 2017
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46