Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper default public_key_type for google_service_account_key #686

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Set proper default public_key_type for google_service_account_key #686

merged 1 commit into from
Nov 6, 2017

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Nov 5, 2017 •
edited by rosbo
Loading

Fixes #684

rosbo
rosbo approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rosbo rosbo merged commit b9eac81 into hashicorp:master Nov 6, 2017
@rosbo rosbo changed the title correct issue #684 Set proper default public_key_type for google_service_account_key Nov 6, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician
Allow project to be specified when importing instance groups (hashico…
7e03179 
…rp#686)

Signed-off-by: Modular Magician <magic-modules@google.com>
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Revert "Allow project to be specified when importing instance groups (h…
9c8231f 
…ashicorp#686)" (hashicorp#690)

This reverts commit 7e03179.
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rosbo rosbo rosbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default public_key_type for google_service_account_key is invalid
2 participants
@sebglon @rosbo