Fix timeout issue with project services #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failling. Can't build the test... google/resource_google_project_services.go:208:14: too many arguments in call to retry |
|
whoops, fixed. |
rosbo
approved these changes
Nov 14, 2017
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the retry function (which was set to retry for one minute) was conflicting with our operation wait (which was set to retry for ten minutes) and winning. I looked through the code and it really seems like that the first iteration through the retry it should wait for the function to return, which would take the full ten minutes (or whenever the api is done getting enabled) but this at least fixes it.
I definitely agree that we should have configurable timeouts, but it's a bit complicated with project_services because it makes as many API calls as there are APIs to enable or disable in a given run, and we usually do a timeout per create/read/update/delete function and I don't want it to be misleading. We could pretty easily add it to the fine-grained project_service resource, but it's not as urgent now that the timeout is actually getting set to the value we had set it to originally.
I'll go ahead and say this fixes #722.