New, very simple data sources for GCR Repo and Image. #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks @ndmckinley looks good |
rosbo
reviewed
Jan 17, 2018
google/provider.go
Outdated
| @@ -75,7 +76,8 @@ func Provider() terraform.ResourceProvider { | |||
| "google_compute_region_instance_group": dataSourceGoogleComputeRegionInstanceGroup(), | |||
| "google_container_cluster": dataSourceGoogleContainerCluster(), | |||
| "google_container_engine_versions": dataSourceGoogleContainerEngineVersions(), | |||
| "google_active_folder": dataSourceGoogleActiveFolder(), | |||
| "google_gcr_repository": dataSourceGoogleGcrRepo(), | |||
There was a problem hiding this comment.
should we use the acronym GCR or expand it to container_registry.
It is also weird to have google_g(oogle)c(ontainer)r(egistry)_repository. google is repeated twice.
There was a problem hiding this comment.
Agreed - expanded it.
rosbo
reviewed
Jan 18, 2018
| @@ -9,7 +9,7 @@ import ( | |||
| func TestDataSourceGoogleGcrRepository(t *testing.T) { | |||
rosbo
reviewed
Jan 18, 2018
| } | ||
| } | ||
|
|
||
| func gcrRepoRead(d *schema.ResourceData, meta interface{}) error { |
|
For reasons I can't figure out, these new docs are crashing the website. I know it's got to be these because it doesn't happen on master, and it does happen on this branch, even with the branch rebased on top of master. The error message is not helping me: Any ideas? |
|
Rename also the go files. |
rosbo
reviewed
Jan 18, 2018
|
|
||
| This data source fetches the project name, and provides the appropriate URLs to use for container registry for this project. | ||
|
|
||
| The URLs are computed entirely offline - as long as the project exists, they will be valid, but this data source does not contact GCR at any point. |
There was a problem hiding this comment.
If you want to use the GCR acronym, you should spell it out fully the first time you use it and add the acronym between parentheses after it.
rosbo
reviewed
Jan 18, 2018
| "github.com/hashicorp/terraform/helper/schema" | ||
| ) | ||
|
|
||
| func dataSourceGoogleContainerRepo() *schema.Resource { |
There was a problem hiding this comment.
I would split the 2 data sources in different files to follow our convention of one resource or one data source per source file
rosbo
approved these changes
Jan 18, 2018
|
I take back what I said about the website - error repros when I delete both the files I added and use the google.erb from master, so this change probably doesn't cause that issue. |
|
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
New, very simple data sources for GCR Repo and Image, plus docs.
modular-magician
pushed a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Add project import regex
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixed #607, but I'm a little fuzzy on the use-case there, so I'd like someone who requested / thumbs-up'd that to look at the code and make sure it's helpful before I invest the time in writing the docs.