Fix issue where group member entities were lost #1409
Merged
+430
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The identity_group resource was removing the member_entity_ids when configured with external_member_entity_ids. In this case the member_entity_ids are handled externally and should not be modified by the identity_group resource. The issue only manifested on resource update when any of the tracked fields had changes. Fixes: - completely re-work the tests for identity_group_member_entity_ids, making them more reliable - add test cases that include changing a identity_group's group_name, which triggers the issue in the identity_group resource - make set type operations simpler - numerous other fixes
| return fmt.Errorf("resource not found in state") | ||
| } | ||
| // vaultStateTest | ||
| type vaultStateTest struct { |
vinay-gopalan
approved these changes
Apr 11, 2022
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
The identity_group resource was removing the member_entity_ids when configured with external_member_entity_ids. In this case the member_entity_ids are handled externally and should not be modified by the identity_group resource. The issue only manifested on resource update when any of the tracked fields had changes. Fixes: - completely re-work the tests for identity_group_member_entity_ids, making them more reliable - add test cases that include changing a identity_group's group_name, which triggers the issue in the identity_group resource - make set type operations simpler - numerous other fixes - add extra group name change to the dynamic test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
identity_groupresource was removing themember_entity_idswhenconfigured with
external_member_entity_ids. In this case themember_entity_idsare handled externally and should not be modified bythe
identity_groupresource. The issue only manifested on resourceupdate when any of the tracked fields had changes.
Fixes:
identity_group_member_entity_ids, making them more reliable
which triggers the issue in the identity_group resource
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: