Use the path for data.vault_generic_secret ID #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
kalafut
approved these changes
Aug 21, 2020
headcr4sh
approved these changes
Aug 21, 2020
This was referenced Sep 29, 2020
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform 0.13.0 introduces the values for data sources to be read as part of the
planphase. Once a generic secret is written to state, future plan or applies will change the ID because it's using theRequestIDthat read it as the ID. This is demonstrated in #847Here we change the data source to use the
pathattribute instead, which should remain unique. It's also unlikely that anyone would be usingdata.vault_generic_secret.name.idas an input value, as it's a UUID from Vault that identifies that specific request that read the value and provides no actual value outside of that.Fixes #847