Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our coverage checking config with coveralls.io is broken #1017

Closed
john-science opened this issue Dec 11, 2022 · 5 comments · Fixed by #1020
Closed

Our coverage checking config with coveralls.io is broken #1017

john-science opened this issue Dec 11, 2022 · 5 comments · Fixed by #1020
Assignees
Labels
bug Something is wrong: Highest Priority

Comments

@john-science
Copy link
Member

On Friday, our coveralls.io CI, which displays and reports our code coverage, broke.

The only clue as to why it broke is it is complaining we need a auth token in our GH Actions env.

Well, fine. But I don't have permissions to log into the ARMI coveralls.io account and find such a token. And the last 15 months we certainly haven't used one. So. Unless @youngmit or @ntouran have access to that coveralls.io account, that is dead in the water. BUT... honestly, coveralls has always been flaky (see this ticket.

Our build will be broke until we ditch coveralls.io.

@john-science john-science added the bug Something is wrong: Highest Priority label Dec 11, 2022
@john-science john-science self-assigned this Dec 11, 2022
@ntouran
Copy link
Member

ntouran commented Dec 11, 2022

Yeah I'm like 99% sure I have that login. We can configure the auth there as needed, shouldn't be too hard. maybe our original token expired.

@john-science
Copy link
Member Author

Holler when you find it!

@ntouran
Copy link
Member

ntouran commented Dec 12, 2022

Ok I have it. The error you linked above says:

coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

So I guess we can just set the COVERALLS_REPO_TOKEN to the token I see in our GH Actions config somewhere, eh?

@ntouran
Copy link
Member

ntouran commented Dec 12, 2022

I am looking for more explicit docs explaining this though. Right now when you go to https://docs.coveralls.io/ and click on the github actions thing it takes you to their nicely-packaged coveralls GH action which I don't think we're using. We only mention coveralls in the tox.ini file. Maybe we should adjust our config to be up-to-date with the services docs?

@ntouran
Copy link
Member

ntouran commented Dec 12, 2022

Anyway, my PR did ok but not all the way. commenting in there as we work though it.

@ntouran ntouran changed the title coveralls.io is broken Our coverage checking config with coveralls.io is broken Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants