-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more font optimization: subset by style #1107
Comments
@donglixiaoche can you leave a comment here so i can assign you? (github won't let me assign otherwise) |
@alixander coooopy, wanna give this issue a shot |
@alixander when will a text be type Text struct {
Label string `json:"label"`
FontSize int `json:"fontSize"`
FontFamily string `json:"fontFamily"`
Language string `json:"language"`
Color string `json:"color"`
Italic bool `json:"italic"`
Bold bool `json:"bold"`
Underline bool `json:"underline"`
LabelWidth int `json:"labelWidth"`
LabelHeight int `json:"labelHeight"`
LabelFill string `json:"labelFill,omitempty"`
} |
ohh i see, when there is markdown inside diagram, right? when will there be a markdown ? an explanation? |
Lines 1373 to 1394 in feae388
and why do we need regular font for |
currently we subset fonts by collecting all characters and encoding, in every style, those characters.
we can further optimize by subsetting each character WITH its style, so that the font encoding for bold only includes the bolded characters, the font encoding for italic only includes the italics, etc.
related initial optimization: #1089
The text was updated successfully, but these errors were encountered: