Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shape size with empty markdown render #1223

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Fix shape size with empty markdown render #1223

merged 5 commits into from
Apr 18, 2023

Conversation

gavin-ts
Copy link
Contributor

Summary

Fixes a bug where shapes with an (effectively) empty markdown label could cause layout bugs due to having 0 for their dimensions.

Details

before/after

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (8)

@gavin-ts gavin-ts marked this pull request as ready for review April 18, 2023 20:14
@gavin-ts gavin-ts requested a review from a team April 18, 2023 20:14
@gavin-ts gavin-ts merged commit 7f3c2c7 into terrastruct:master Apr 18, 2023
@Porkepix Porkepix mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I was told to share this error link
2 participants
@gavin-ts @alixander