Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for empty labels on text shape #1590

Merged
merged 4 commits into from
Sep 18, 2023
Merged

check for empty labels on text shape #1590

merged 4 commits into from
Sep 18, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Sep 18, 2023 •
edited
Loading

Summary

Text shape labels should not be empty.

Details

  • we only validated that labels were not empty for blockstrings, but didn't validate double and single quote labels for shape text
  • add compile test
  • add validation step

@gavin-ts gavin-ts requested a review from alixander September 18, 2023 21:00
@gavin-ts gavin-ts marked this pull request as ready for review September 18, 2023 21:10
@gavin-ts gavin-ts merged commit 4c108d8 into terrastruct:master Sep 18, 2023
2 checks passed
@Porkepix Porkepix mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavin-ts @alixander