Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grid-rows with horizontal-gap > vertical-gap #1640

Closed
gavin-ts opened this issue Oct 5, 2023 · 0 comments · Fixed by #1646
Closed

fix grid-rows with horizontal-gap > vertical-gap #1640

gavin-ts opened this issue Oct 5, 2023 · 0 comments · Fixed by #1646
Labels
bug Something isn't working layout

Comments

@gavin-ts
Copy link
Contributor

gavin-ts commented Oct 5, 2023

If there is a grid, with only grid-rows specified and not grid-columns, and if horizontal-gap is set to a positive value greater than vertical-gap, then the grid container may end up too short. This doesn't seem to happen with grid-columns.

Screenshot 2023-10-04 at 5 42 47 PM
grid: "" {
  grid-rows: 3
  horizontal-gap: 100
  vertical-gap: 0
  first
  second
  third
}

grid2: "" {
  grid-rows: 3
  horizontal-gap: 50
  vertical-gap: 0
  first
  second
  third
}

grid3: "" {
  grid-rows: 3
  horizontal-gap: 10
  vertical-gap: 0
  first
  second
  third
}

grid4: "" {
  grid-rows: 3
  horizontal-gap: 0
  vertical-gap: 0
  first
  second
  third
}

grid5: "" {
  grid-columns: 3
  horizontal-gap: 0
  vertical-gap: 100
  first
  second
  third
}

grid6: "" {
  grid-columns: 3
  horizontal-gap: 0
  vertical-gap: 10
  first
  second
  third
}
@gavin-ts gavin-ts added bug Something isn't working layout labels Oct 5, 2023
@cyborg-ts cyborg-ts added this to D2 Oct 5, 2023
@github-project-automation github-project-automation bot moved this to Done in D2 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working layout
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant