Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default triangle arrowhead should also have filled: false #1650

Closed
alixander opened this issue Oct 7, 2023 · 8 comments · Fixed by #1711
Closed

default triangle arrowhead should also have filled: false #1650

alixander opened this issue Oct 7, 2023 · 8 comments · Fixed by #1711
Assignees
Labels
good first issue Good for newcomers

Comments

@alixander
Copy link
Collaborator

we have it for diamond and circle, but triangle unfilled has meaning in uml too

https://d2lang.com/tour/connections/#arrowheads

@alixander alixander added the good first issue Good for newcomers label Oct 7, 2023
@cyborg-ts cyborg-ts added this to D2 Oct 7, 2023
@aakashdeepsil
Copy link

Hi team
I want to contribute to this story. I'm very new to open source. I think this looks like a good place to begin. Can I start working on this?

@alixander
Copy link
Collaborator Author

@aakashdeepsil All yours!

Perhaps @Paracelsus-Rose's PR on #634 would be a good example starting point. His code adds a new arrowhead, which includes a filled version.

@aakashdeepsil
Copy link

I will go through the PR to understand the work well. Then start the work on this issue. Might take me a day to understand the PR well. I will start work from tomorrow.

@alixander
Copy link
Collaborator Author

@gavin-ts can you knock this out?

@hinogi
Copy link

hinogi commented Nov 7, 2023

I already tried shape: triangle style.filled: false but that didn't work for target arrowhead

@PackRuble
Copy link

Trying the v.0.6.2 release and it doesn't seem to work:

A1 -> A2: {
  target-arrowhead.shape: triangle
  style.filled: false
}

B1 -> B2: {
  target-arrowhead.shape: arrow
  style.filled: false
}

C1 -> C2: {
  target-arrowhead.shape: circle
  style.filled: true
}

image

@alixander
Copy link
Collaborator Author

@hinogi @PackRuble

The style pertains to the arrowhead, not the connection.

A1 -> A2: {
  target-arrowhead.shape: triangle
  target-arrowhead.style.filled: false
}

C1 -> C2: {
  target-arrowhead.shape: circle
  target-arrowhead.style.filled: true
}
Screen Shot 2023-12-07 at 4 08 46 AM

https://play.d2lang.com/?script=cjRU0LVTcDSyUqjmUlAoSSxKTy3RTSwqyi_PSE1M0SvOSCxItVIoKcpMzEvPScWqpKQyJ1UvLTMnJzXFSiEtMac4lauWi8sZbLAzAYOTM4uSiTG2pKgUZCogAAD__w%3D%3D&

@PackRuble
Copy link

@alixander Thank you very much, I apologize for the inattention. Using target-arrowhead.style.filled helped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants