Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make connection style.fill more aesthetic #2030

Closed
alixander opened this issue Jul 30, 2024 · 2 comments · Fixed by #2094
Closed

make connection style.fill more aesthetic #2030

alixander opened this issue Jul 30, 2024 · 2 comments · Fixed by #2094

Comments

@alixander
Copy link
Collaborator

alixander commented Jul 30, 2024

what we want

Screenshot 2024-07-29 at 11 29 35 PM

what it is currently

Screenshot 2024-07-29 at 11 30 47 PM
  • More padding
  • Rounded corners
@cyborg-ts cyborg-ts added this to D2 Jul 30, 2024
@bo-ku-ra
Copy link
Contributor

bo-ku-ra commented Jul 30, 2024

i want

  • connection style and connection label style can be specified separately.
  • connection label and markdown support 'border(stroke)'.

ex.1)

a->b:foobar{
   #for connection
   style{
   stroke-dash: 5;
   stroke: orange;
   }

   #for connection label
   label.style{
   fill:orange

   width: 100;          #for padding
   near:center-center;  #for padding

   double-border: true;
   border-radius: 20;
   stroke-dash: 2;
   stroke-width: 5;
   stroke: red;
   }
}

ex.2)

c->d:|
 foobar
|{ style.fill:orange }

ex.3)different outputs, why? (dupe: #1633)

a -> b

memo: |md
  <div class="container">
    foobar
  </div>
  <style type="text/css">
  .container{
    background-color:orange;
    text-align: center;
    width: 100px;
    border-radius: 9999px;
  }
  </style>
|

y -> z: |md
  <div class="container">
    foobar
  </div>
  <style type="text/css">
  .container{
    background-color:orange;
    text-align: center;
    width: 100px;
    border-radius: 9999px;
  }
  </style>
|

https://play.d2lang.com/?script=3I9BTsMwEEX3I_kOo-xNyzIm9V0m9hAsEk81dksD4e7IXnCIbv__T_qP0HqcDRjYeBN3bNHAFNMdw0qlXIYguVLKrIM3gPguMpMamE4x3b2BqdR9Zaz7lS9D5Uc9hVLa9OUf_GncTOFzUbnlaIOsok6U8sJvrWuYpTUt2WHgXFl7_JVi_XD4ej5fHz2YRSOrVYrpVhyO4zj25rfd6T-8gaOp7NZ_P4EK_AUAAP__&

@i-am-the-slime
Copy link

No padding around connection labels often makes the text connect with the arrows when fill is the same as the background colour. I'd very much appreciate more padding and rounded corners!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants