Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Cache remote images in watch mode for PNGs #243

Closed
alixander opened this issue Nov 28, 2022 · 0 comments · Fixed by #1373
Closed

cli: Cache remote images in watch mode for PNGs #243

alixander opened this issue Nov 28, 2022 · 0 comments · Fixed by #1373
Labels
cli This issue is related to the CLI (cmd/d2) improvement Something can be better

Comments

@alixander
Copy link
Collaborator

alixander commented Nov 28, 2022 •
edited
Loading

Since we inline images for PNG exports: #224

While local files can reasonably change compile to compile, remote images should be safe to cache in memory for the entirety of a watch session
@alixander alixander added cli This issue is related to the CLI (cmd/d2) improvement Something can be better labels Nov 28, 2022
@alixander alixander added this to D2 Nov 28, 2022
This was referenced Jun 2, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this to Done in D2 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli This issue is related to the CLI (cmd/d2) improvement Something can be better
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli img fetching optimizations alixander/d2
1 participant
@alixander