Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dagre: ensure sufficient space between shapes for large edge labels #263

Closed
gavin-ts opened this issue Nov 29, 2022 · 1 comment · Fixed by #484
Closed

dagre: ensure sufficient space between shapes for large edge labels #263

gavin-ts opened this issue Nov 29, 2022 · 1 comment · Fixed by #484
Assignees
@gavin-ts

Comments

@gavin-ts
Copy link
Contributor

gavin-ts commented Nov 29, 2022 •
edited
Loading 

a -> b: There\nonce\nwas\na\nvery\ntall\nedge\nlabel

Screen Shot 2022-11-29 at 1 43 05 PM

this can happen with some dagre layouts
@gavin-ts gavin-ts changed the title layouts: ensure enough space for large edge labels layouts: ensure sufficient space between shapes for large edge labels Nov 29, 2022
@gavin-ts gavin-ts changed the title layouts: ensure sufficient space between shapes for large edge labels dagre: ensure sufficient space between shapes for large edge labels Nov 29, 2022
@gavin-ts gavin-ts mentioned this issue Nov 29, 2022
Merged
@nhooyr nhooyr added this to D2 Dec 1, 2022
@alixander
Copy link
Collaborator

a horizontal example: https://play.d2lang.com/?script=lJLNSsNAFIX39ynOyl1ELG6CFKKLdllIwaVMzDQzOMmE-bFU6bvL3LYxiGBnkU1y7pd7vplJXwmX2hM1UZv2dW_d-87YfYkvAthBCSP6phUFJ24PojdEwBi9OqWm3CZ6hWDRCz2gcWJ4U_yZ971kgUl8ifsHfnek9BCwWle_mCsd1rFBxcv6TFy9uMSun9lK58TOuj5_tHqp84eSRxTLP6pvne466f4tfTcDssKE-6l-pj2l0_P41CNu-KfSQ4c8dr3AY7GcK9pEY07QYNHK0djD3GHahK08KzF00iMoCaM_5PlOeTrSdwAAAP__&layout=dagre

@gavin-ts gavin-ts mentioned this issue Dec 21, 2022
Merged
@gavin-ts gavin-ts moved this to Done in D2 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavin-ts gavin-ts

Labels
None yet
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

render: dagre layout min spacing gavin-ts/d2
2 participants
@alixander @gavin-ts