Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3d on hexagon shape #869

Closed
alixander opened this issue Feb 22, 2023 · 5 comments
Closed

3d on hexagon shape #869

alixander opened this issue Feb 22, 2023 · 5 comments
Assignees
@JettChenT
Labels
good first issue Good for newcomers render

Comments

@alixander
Copy link
Collaborator

220769755-8f1bda9d-ff20-459f-bb5a-7fae11a90aae

related: #868
@alixander alixander added good first issue Good for newcomers render labels Feb 22, 2023
@cyborg-ts cyborg-ts added this to D2 Feb 22, 2023
@alixander alixander mentioned this issue Feb 22, 2023
Open
@JettChenT
Copy link
Contributor

JettChenT commented Feb 24, 2023 •
edited
Loading

Hi! I'm willing to work on this issue.
I'm wondering if there is existing documentation on the SVG library and if there is an API for drawing dotted lines in the SVG library to create the 3D perspective effect. Alternatively, I can implement a loop to achieve this or only draw the visible lines.
Thanks!

@JettChenT
Copy link
Contributor

Here's my current progress:
CleanShot 2023-02-25 at 00 02 15@2x

@alixander
Copy link
Collaborator Author

awesome! no documentation unfortunately.

API for drawing dotted lines in the SVG library to create the 3D perspective effect.

ohh very interesting. there isn't. i'm guessing you'll want to split it up into multiple paths or lines, and the ones behind will get lower opacity and dashed properties.

i wonder if this exact image will be the best rendering of 3d for hexagon. it doesn't look like a lot of space for a label/icon. i'll let our designer @katwangy take a look this morning and chime in

@alixander
Copy link
Collaborator Author

Screen Shot 2023-02-24 at 10 41 14 AM

I would agree with that, the different perspective could look weird. can you change to doing this please? Sorry for that, I know you already started @JettChenT

@JettChenT
Copy link
Contributor

Thanks a lot! I'll change this to the new design right away.

@JettChenT JettChenT mentioned this issue Feb 25, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in D2 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JettChenT JettChenT

Labels
good first issue Good for newcomers render
Projects
D2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alixander @JettChenT