Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with local icons in 2.1 #889

Closed
zachcp opened this issue Feb 24, 2023 · 3 comments · Fixed by #890
Closed

Issue with local icons in 2.1 #889

zachcp opened this issue Feb 24, 2023 · 3 comments · Fixed by #890
Assignees

Comments

@zachcp
Copy link

zachcp commented Feb 24, 2023

Local images using both icon and shape work with D2 v.02 but break with D2 v0.2.1. See below.

my network: {
    icon: https://icons.terrastruct.com/infra/019-network.svg
}

my network2: {
    shape: image
    icon: https://icons.terrastruct.com/infra/019-network.svg
}

my network3: {
    #wget https://icons.terrastruct.com/infra/019-network.svg
    shape: image
    icon: 019-network.svg
}
my network4: {
    #wget https://icons.terrastruct.com/infra/019-network.svg
    #shape: image
    icon: "./019-network.svg"
}

image

@cyborg-ts cyborg-ts added this to D2 Feb 24, 2023
@alixander
Copy link
Collaborator

wait wget was working before?

@zachcp
Copy link
Author

zachcp commented Feb 24, 2023

wait wget was working before?

No I'm just showing you that I'm trying to use the exact same icon but locally

@alixander
Copy link
Collaborator

alixander commented Feb 24, 2023

can reproduce, we'll get this fixed today, ty for reporting @zachcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants