copySync errors swallowed, hanging deploy

[HipsterBrown]

While working on a smoke test for t2-compiler, the deployment would hang after INFO Connected to.... I discovered this was due to fs.copySync blocking errors inside of the actions.injectBinaryModules function.

[johnnyman727]

@HipsterBrown could this also be the cause of #271? Or maybe just one of a number of causes.

[HipsterBrown]

It could be. The best practice in the future would be to add a .catch() to every Promise chain, so we can throw or reject those swallowed errors.

[johnnyman727]

👍 good point. I'll keep my eye out to see if I hit this hanging issue anymore. I've tried to make sure all errors are being passed up the chain but it's totally possible I missed a few cases.