Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must have git installed to download t2 cli #136

Closed
Frijol opened this issue Jul 16, 2016 · 11 comments
Closed

Must have git installed to download t2 cli #136

Frijol opened this issue Jul 16, 2016 · 11 comments

Comments

@Frijol
Copy link
Member

Frijol commented Jul 16, 2016

We should note this prerequisite

@HipsterBrown
Copy link
Contributor

Why is it a prerequisite?

@johnnyman727
Copy link
Contributor

I believe npm uses it to fetch npm dependencies that have a git url listed as the source.

@HipsterBrown
Copy link
Contributor

Makes sense. Thanks for clarifying! 👍

@dtex
Copy link

dtex commented Jul 18, 2016

Why is there a special npmlog at all?

Sorry if this is a known thing already, just seems weird.

@rwaldron
Copy link
Contributor

rwaldron commented Jul 18, 2016

There wouldn't be if anyone at npm would follow on this: npm/npmlog#34 npm/npmlog#31

Sorry if this is a known thing already, just seems weird.

Yes. Please help me get the attention of someone at npm

@dtex
Copy link

dtex commented Jul 18, 2016

@rwaldron I know you have strong feelings about not polluting the npm ecosystem and I don't disagree one bit, but in this case would it be worth it for T2 users to go ahead and publish your version?

I know most early adopters will of course have git, but with people ordering the J5IK and T2's figuring into Nodebots Day there are going to be people who are not git users coming into our community.

The readme could be updated to read something along the lines of:

Don't use this package in your project! It's for the T2-CLI only. 

Use this instead: https://www.npmjs.com/package/npmlog

It's a temporary fork of npmlog and shouldn't even exist, but until our PR lands we've gotta do this.

Similar problem getting a merge here: npm/fstream#16 Note the date that this PR was submitted

@dtex
Copy link

dtex commented Jul 18, 2016

To be fair, it looks like some work is being done on the fstream PR.

@rwaldron
Copy link
Contributor

@dtex yes, I think you're right. I will do exactly as you've suggested.

@rwaldron
Copy link
Contributor

This can be closed, there is no git dep in the coming release

@HipsterBrown
Copy link
Contributor

Closing this as fixed by @rwaldron with tessel/t2-cli@ee98070

@rwaldron
Copy link
Contributor

@HipsterBrown thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants