missing --coverage in gcc_coverage build environment

[zjuchenyuan]

I'm trying with mp3gain, this program do not provide configure, so touch configure && chmod +x configure first.

# orthrus create -cov
Orthrus 1.2 by Bhargava Shastry, and Markus Leutner <https://github.com/test-pipeline/orthrus>

[+] Creating Orthrus workspace
                [+] Checking if workspace exists... done
                [+] Configuring... done
                [+] Compiling... failed
        [+] Installing binaries for obtaining test coverage information... failed


cat .orthrus/logs/gcc_coverage.log
rm -rf mp3gain mp3gain.zip mp3gain.o apetag.o id3tag.o gain_analysis.o rg_error.o
gcc -g -O0 -fprofile-arcs -ftest-coverage -Wall -DHAVE_MEMCPY   -c -o mp3gain.o mp3gain.c
gcc -g -O0 -fprofile-arcs -ftest-coverage -Wall -DHAVE_MEMCPY   -c -o apetag.o apetag.c
gcc -g -O0 -fprofile-arcs -ftest-coverage -Wall -DHAVE_MEMCPY   -c -o id3tag.o id3tag.c
gcc -g -O0 -fprofile-arcs -ftest-coverage -Wall -DHAVE_MEMCPY   -c -o gain_analysis.o gain_analysis.c
gcc -g -O0 -fprofile-arcs -ftest-coverage -Wall -DHAVE_MEMCPY   -c -o rg_error.o rg_error.c
mp3gain.c: In function ‘changeGain’:
mp3gain.c:702:7: warning: variable ‘freqidx’ set but not used [-Wunused-but-set-variable]
   int freqidx;
       ^
mp3gain.c: In function ‘main’:
mp3gain.c:1465:6: warning: variable ‘crcflag’ set but not used [-Wunused-but-set-variable]
  int crcflag;
      ^
apetag.c: In function ‘ReadMP3APETag’:
apetag.c:165:33: warning: variable ‘curFieldNum’ set but not used [-Wunused-but-set-variable]
     unsigned long               curFieldNum;
                                 ^
apetag.c:154:33: warning: variable ‘flags’ set but not used [-Wunused-but-set-variable]
     unsigned long               flags;
                                 ^
gcc -lgcov -o mp3gain mp3gain.o apetag.o id3tag.o gain_analysis.o rg_error.o  -lm -lmpg123
mp3gain.o: In function `_GLOBAL__sub_I_65535_0_writeself':
/work/output/orthrus/mp3gain.c:2764: undefined reference to `__gcov_init'
mp3gain.o:(.data+0x80): undefined reference to `__gcov_merge_add'
apetag.o: In function `_GLOBAL__sub_I_65535_0_ReadMP3ID3v1Tag':
/work/output/orthrus/apetag.c:694: undefined reference to `__gcov_init'
apetag.o:(.data+0x60): undefined reference to `__gcov_merge_add'
id3tag.o: In function `_GLOBAL__sub_I_65535_0_ReadMP3GainID3Tag':
/work/output/orthrus/id3tag.c:1417: undefined reference to `__gcov_init'
id3tag.o:(.data+0x60): undefined reference to `__gcov_merge_add'
gain_analysis.o: In function `_GLOBAL__sub_I_65535_0_ResetSampleFrequency':
/work/output/orthrus/gain_analysis.c:479: undefined reference to `__gcov_init'
gain_analysis.o:(.data+0x60): undefined reference to `__gcov_merge_add'
rg_error.o: In function `_GLOBAL__sub_I_65535_0_DoError':
/work/output/orthrus/rg_error.c:63: undefined reference to `__gcov_init'
rg_error.o:(.data+0x60): undefined reference to `__gcov_merge_add'
collect2: error: ld returned 1 exit status
Makefile:55: recipe for target 'mp3gain' failed
make: *** [mp3gain] Error 1

And I found: https://stackoverflow.com/questions/16682606/how-to-resovle-gcov-init-undefined-reference-issue-when-link

which says LFLAGS: -lgcov --coverage, so I make this patch before python setup.py install and it works:

sed -i "s#'-lgcov'#'-lgcov --coverage'#g" orthrus/builder/builder.py

related code:

orthrus/builder/builder.py

Lines 46 to 47 in 7e916f3

	BEnv_gcc_coverage = BEnv('gcc', 'g++', '-g -O0 -fprofile-arcs -ftest-coverage',
	'-g -O0 -fprofile-arcs -ftest-coverage', '-lgcov', '-lgcov', {})