Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy Analysis Extension - Reporting doesn't work when the build is failed and no snapshots are uploaded in Percy #113

Closed
sadeesh-sdet opened this issue Jan 12, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@sadeesh-sdet
Copy link
Contributor

Considering the use-case that a percy's visual test is failed even at functional step(ex: elements' locator change) before executing the visual tests and because of this, the build/test will fail and the same will be captured like below in Percy

image

In this case, the reporter plugin doesn't notify the results and its execution doesn't stop. Guess, it keeps on retry here.

@ASaiAnudeep
Copy link
Member

what is the state of the build when it has failed?

@sadeesh-sdet
Copy link
Contributor Author

sadeesh-sdet commented Jan 12, 2023

image
I see, the state for this case is "failed". Please check this reference from percy

@ASaiAnudeep ASaiAnudeep added the bug Something isn't working label Jan 13, 2023
@ASaiAnudeep
Copy link
Member

do you want to raise a PR with a fix?

@sadeesh-sdet
Copy link
Contributor Author

@ASaiAnudeep Many thanks for this kind opportunity. Let me give it a try and test this by including the "failed" case in this condition step and a regression around it.

@sadeesh-sdet
Copy link
Contributor Author

@ASaiAnudeep Please review this pull request as it has been addressed and resolved this observation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants