-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: v0.27.0 breaks bind mounts #2179
Comments
FYI @mdelapenya |
@srabraham Hi! I hope you are doing well! |
More on this: using the HostConfigModifier works, so you still have a workaround. In your repro project you can add this to the ContainerRequest: HostConfigModifier: func(hc *container.HostConfig) {
hc.Binds = []string{mountFile + ":" + containerDir}
}, This narrows down the issue to the BindMount type, so I'm continuing with the debug in that direction. Will update here my results. |
Ahhh it was easy!! In https://github.com/testcontainers/testcontainers-go/pull/1907/files#diff-f8dd512f57a3d3bc890983ea0164e44d1aa69034527ccf41217f0f2807a76917L6 I'm removing the deprecated type from the list, which should not be done until the type is removed, my bad 🤦 Submitting a fix now. |
Ahhh, good find! Thanks for the speedy service! |
Would you mind giving a second try to the repro steps using the above PR? 🙏 A review will be appreciated too |
Verified! I commented on the PR too. Thank you |
tl;dr: Please see this demo, which you can clone and run at 0.26.0 and 0.27.0. There's documentation in the main.go
https://github.com/srabraham/demobindmount/blob/main/main.go
Testcontainers version
0.27.0
Using the latest Testcontainers version?
Yes
Host OS
OSX
Host arch
arm64
Go version
1.21
Docker version
Client: Cloud integration: v1.0.35+desktop.5 Version: 24.0.7 API version: 1.43 Go version: go1.20.10 Git commit: afdd53b Built: Thu Oct 26 09:04:20 2023 OS/Arch: darwin/arm64 Context: desktop-linux Server: Docker Desktop 4.26.1 (131620) Engine: Version: 24.0.7 API version: 1.43 (minimum version 1.12) Go version: go1.20.10 Git commit: 311b9ff Built: Thu Oct 26 09:08:15 2023 OS/Arch: linux/arm64 Experimental: false containerd: Version: 1.6.25 GitCommit: d8f198a4ed8892c764191ef7b3b06d8a2eeb5c7f runc: Version: 1.1.10 GitCommit: v1.1.10-0-g18a0cb0 docker-init: Version: 0.19.0 GitCommit: de40ad0
Docker info
What happened?
Please see this demo, which you can check out and run at 0.26.0 and 0.27.0. There's documentation in the main.go
https://github.com/srabraham/demobindmount/blob/main/main.go
Relevant log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: