Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: TestContainerLogWithErrClosed #411

Closed
mdelapenya opened this issue Feb 28, 2022 · 2 comments · Fixed by #455
Closed

Flaky test: TestContainerLogWithErrClosed #411

mdelapenya opened this issue Feb 28, 2022 · 2 comments · Fixed by #455
Labels
test flakiness Report a flaky test that happens on the CI

Comments

@mdelapenya
Copy link
Member

I noticed this test is randomly failing. We'd need to further investigate why it fails and in which conditions. It may be written in a way that is not consistent, or maybe not up-to-date. Opening this issue for awareness.

=== RUN   TestContainerLogWithErrClosed
2022/02/28 16:27:00 Starting container id: 07de0af25f64 image: docker:dind
2022/02/28 16:27:00 Waiting for container id 07de0af25f64 image: docker:dind
2022/02/28 16:27:17 Container is ready id: 07de0af25f64 image: docker:dind
    logconsumer_test.go:210: port not found
--- FAIL: TestContainerLogWithErrClosed (20.54s)
@mdelapenya mdelapenya added the test flakiness Report a flaky test that happens on the CI label Feb 28, 2022
@prskr
Copy link
Contributor

prskr commented Apr 11, 2022

I stumbled upon this issue while working on #414 I think it should be resolved in my PR by correctly using the PortEndpoint(ctx context.Context port nat.Port, proto string) (string, error) function

@mdelapenya
Copy link
Member Author

mdelapenya commented May 19, 2022

Gotestsum supports rerunning failed tests: https://github.com/gotestyourself/gotestsum#re-running-failed-tests

We could give it a try for adding stability to the pipeline meanwhile we investigate this flakiness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test flakiness Report a flaky test that happens on the CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants