Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More customizable postgres container #220

Merged
merged 3 commits into from
Sep 22, 2016
Merged

Conversation

barlog-m
Copy link
Contributor

@barlog-m barlog-m commented Sep 9, 2016

Postgres docker container can be with custom database name, user name and password. Sometimes it is necessary.

}

public PostgreSQLContainer(String dockerImageName) {
public PostgreSQLContainer(final String dockerImageName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use this(dockerImageName, "test", "test", "test")

@rnorth
Copy link
Member

rnorth commented Sep 11, 2016

Looks good to me - just one thing. I've generally erred away from constructor args for containers (apart from specifying container image name), and gone for fluent setters instead.

Is there a reason why the fluent setter pattern can't be used here? I'd prefer to be as consistent as possible...

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I'll check out and have a play locally, then merge. Thanks for this.

@rnorth rnorth merged commit beabd2b into testcontainers:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants