Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Docker-in-Docker references #278

Merged
merged 1 commit into from
Jan 22, 2017
Merged

Rename Docker-in-Docker references #278

merged 1 commit into from
Jan 22, 2017

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Jan 22, 2017

…to 'running inside docker' to avoid confusion with the DinD project which is not quite the same thing (DinD is probably a subset of what Testcontainers supports)

…d confusion with the DinD project which is not _quite_ the same thing (DinD is probably a _subset_ of what Testcontainers supports)
@rnorth rnorth requested a review from bsideup January 22, 2017 08:04
@rnorth
Copy link
Member Author

rnorth commented Jan 22, 2017

What do you think @bsideup - is this accurate? We support volume-mounted docker sockets, whereas DinD is something slightly different. I thought it best to change our reference here just to avoid confusion.

@bsideup
Copy link
Member

bsideup commented Jan 22, 2017

@rnorth got your point. Yes, sounds correct, let's rename it!

@rnorth rnorth merged commit f0ccec9 into master Jan 22, 2017
@rnorth rnorth deleted the further_docs_tweaks branch January 22, 2017 08:27
@bsideup bsideup added this to the 1.1.8 milestone Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants