getServicePort on DockerComposeContainer throws NullPointerException if service instance number in not used. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption if service instance number in not used.
bsideup
approved these changes
Mar 23, 2018
|
@barrycommins nice! Was planning to do exactly that :D Thanks for contributing it :) |
kiview
approved these changes
Mar 23, 2018
|
LGTM, I just deleted the corrupted Travis caches and restarted the build, should suceed now. |
|
Great! Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a minor one, but maybe worth fixing for consistency.
It is possible to expose a service in
DockerComposeContainerwithout specifying the instance number:but when you then call
getServicePort("redis", 6379), aNullPointerExceptionis thrown.It works ok with
getServicePort("redis_1", 6379)