Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are inaccurate - DockerComposeContainer.withExposedService does not take a WaitStrategy in 1.6.0 #620

Closed
Mahoney opened this issue Mar 23, 2018 · 5 comments

Comments

@Mahoney
Copy link

Mahoney commented Mar 23, 2018

The Docker Compose docs state that you can wait for a container started by docker compose to come up by calling an overloaded withExposedService passing it a WaitStrategy.

This method doesn't exist - whether because it has been removed or the docs are for a not yet released version.

@Mahoney Mahoney changed the title Docs are inaccurate - DockerComposeContainer withExposedService does not take a WaitStrategy in 1.6.0 Docs are inaccurate - DockerComposeContainer.withExposedService does not take a WaitStrategy in 1.6.0 Mar 23, 2018
@bsideup
Copy link
Member

bsideup commented Mar 23, 2018

@Mahoney actually, the docs are from the future :D We just added this functionality and it is to-be-released soon, but since the docs were changed as part of the PR ( #600 ) you already see it on our website.

@rnorth we should think how to keep docs aligned with the latest release.

Thanks @Mahoney for letting us know 👍

@bsideup
Copy link
Member

bsideup commented Mar 23, 2018

@Mahoney FYI you can use JitPack to try this feature. See how to do it here:
https://www.testcontainers.org/usage.html#maven-dependencies

@kiview
Copy link
Member

kiview commented Mar 23, 2018

@bsideup Versioning of the docs seems like a good idea, we might be able to use this Gitbook plugin:
https://plugins.gitbook.com/plugin/versions

@bsideup
Copy link
Member

bsideup commented Mar 23, 2018

@kiview true. Just maybe we need to cleanup the tags first:
https://api.gitbook.com/book/testcontainers/testcontainers/versions/tags

@bsideup
Copy link
Member

bsideup commented Apr 19, 2018

released as part of 1.7.0

@bsideup bsideup closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants