-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting ryuk.container.timeout causes a ClassCastException #684
Comments
I've created a pull request with the proposed fix. If that PR is approved and merged is it possible to release a patch soon with this fix? |
bsideup
added
type/bug
resolution/pr-submitted
resolution/awaiting-release
and removed
resolution/pr-submitted
labels
May 9, 2018
Released as 1.7.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tried setting
ryuk.container.timeout
by creating atestcontainers.properties
that contains the following:This is successfully picked up, but when TestcontainersConfiguration#getRyukTimeout is called is calls
properties.getOrDefault
, which returns a string "120" which is attempted to be cast to anInteger
. This results in the following error:A fix for this is to change TestcontainersConfiguration#getRyukTimeout to
The text was updated successfully, but these errors were encountered: