Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default images and versions from modules #867

Open
cristianrgreco opened this issue Nov 15, 2024 · 1 comment
Open

Remove default images and versions from modules #867

cristianrgreco opened this issue Nov 15, 2024 · 1 comment
Labels
maintenance Improvements that do not change functionality major An incompatible API change
Milestone

Comments

@cristianrgreco
Copy link
Collaborator

We currently have default images and versions defined for all modules. This means users can start a container effortlessly like new PostgreSqlContainer().start(). This works well when the module is first created and is using the latest versions, but as these versions get out of date, it is not possible for Testcontainers to push a change increasing the default module versions, as it could potentially break the builds of everyone using the default values. It is not feasible to continuously update and push out breaking changes.

The change will simply make the image name and version mandatory, e.g new PostgreSqlContainer("postgres:X.Y.Z").start().

@cristianrgreco cristianrgreco added this to the 11.0.0 milestone Nov 15, 2024
@cristianrgreco cristianrgreco added maintenance Improvements that do not change functionality major An incompatible API change labels Nov 15, 2024
@joebowbeer
Copy link
Contributor

NOTE to check/update the installation examples, too:

https://github.com/testcontainers/community-module-registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements that do not change functionality major An incompatible API change
Projects
None yet
Development

No branches or pull requests

2 participants