Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a setting for cached session clean up #71

Closed
dacoaster opened this issue Jul 18, 2023 · 9 comments · Fixed by #160
Closed

feat: Add a setting for cached session clean up #71

dacoaster opened this issue Jul 18, 2023 · 9 comments · Fixed by #160
Labels
enhancement New feature or request

Comments

@dacoaster
Copy link
Collaborator

dacoaster commented Jul 18, 2023

  • Create a setting for retention days on cached sessions in the ${config}/sessions folder
  • Also add a "clear cache" button on the settings GeneralTab
  • Set up a sane default in config also set on the settings GeneralTab
  • Add a cleanup step in initialization that clears caches older than the retention setting
@dacoaster dacoaster added the enhancement New feature or request label Jul 18, 2023
@dacoaster
Copy link
Collaborator Author

Currently all sessions get a folder with related evidence/files inside. Over time this could consume a lot of disk space after many sessions.

@dacoaster dacoaster added help wanted Extra attention is needed in progress and removed help wanted Extra attention is needed labels Mar 13, 2024
@dacoaster dacoaster added help wanted Extra attention is needed and removed in progress labels Mar 24, 2024
@dacoaster
Copy link
Collaborator Author

@dockabernathy01 - I'll leave this one for you.

@dacoaster dacoaster added in progress and removed help wanted Extra attention is needed labels Mar 25, 2024
@SmartWolf1220
Copy link

@dacoaster, please tell me more about this issue.
Place a "Clear Cache" button to clear the sessions folder.
And if a session has been modified for more than 3 days(retention days), the session folder is automatically deleted.
Is it right?

@SmartWolf1220
Copy link

SmartWolf1220 commented Mar 27, 2024

clear cache
clear cache 1

@dacoaster
Copy link
Collaborator Author

dacoaster commented Mar 27, 2024

@dockabernathy01 Yes

please make the default retention period 7 days and change the wording to "Are you sure you want to clear the local session cache?"

@dacoaster
Copy link
Collaborator Author

@dacoaster, please tell me more about this issue. Place a "Clear Cache" button to clear the sessions folder. And if a session has been modified for more than 3 days(retention days), the session folder is automatically deleted. Is it right?

Yes.

The retention days should go in the config.json as

cache: {
    retentionPeriod: INT
}

the default should be 7 days

@SmartWolf1220
Copy link

SmartWolf1220 commented Mar 27, 2024

@dacoaster , Currently I store retention days like this.
config: {
.....
retentionDays: 7,
}
I think there is no need to make cache object and store retentionDays to cache object.

@dacoaster
Copy link
Collaborator Author

In the future we will likely add more options for managing the cache, so I'd like the key there for now

@SmartWolf1220
Copy link

SmartWolf1220 commented Mar 27, 2024

Ok, I got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants