Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary stuff #1

Open
kentcdodds opened this issue Jul 12, 2019 · 8 comments
Open

Remove unnecessary stuff #1

kentcdodds opened this issue Jul 12, 2019 · 8 comments

Comments

@kentcdodds
Copy link
Member

I don't think there's a reason to include kcd-scripts in here.

Let's see if we can slim this repo down to only what's necessary.

@kentcdodds
Copy link
Member Author

Note that the packages will need to be updated to the right scope. I'd do it myself, but I have limited internet/computer access ATM.

@nickserv
Copy link
Member

Should we archive this repository in favor of https://codesandbox.io/s/react-testing-library-help-uztri? It's a fork of your sandbox, which I believe was forked from this repository.

@alexkrolick
Copy link
Collaborator

Codesandbox has a variety of issues running tests, can we keep this repo and pull in any relevant changes from over there?

@nickserv
Copy link
Member

You can still export a Code Sandbox as a zip or GitHub repository if you have issues with that. I think collaborating on Code Sandbox is easier if we don't need to enforce code reviews, we already have an organization that lets us edit each others templates.

@kentcdodds
Copy link
Member Author

Maybe we could use the node template instead of the react template. That would effectively allow us to do everything.

I use the node template for this repo: https://codesandbox.io/s/github/kentcdodds/testing-node-apps

@nickserv
Copy link
Member

I imagine the in-browser Jest stuff (which should be getting updated soon) would run much faster, as Code Sandbox has to wait for the whole Docker container to boot before Node/Jest can start. I still think it would be a good idea to use containers for things like native testing library and puppeteer that require Node though.

@kentcdodds
Copy link
Member Author

Yes, it is quite a bit slower. Maybe we could do what we do in https://github.com/kentcdodds/react-testing-library-examples

Tests that don't work in codesandbox are in a separate directory and the jest config (which only applies when running locally) will run all the tests.

@nickserv
Copy link
Member

nickserv commented Jul 17, 2020

I think individual sandboxes are easier to use though. It makes the package installation faster and it means that the link can go to a specific file (for example src/index.test.js for React). Also I don't think Code Sandbox supports multiple build tools in a single sandbox without containers.

Alternatively we could have a repository where each directory is a sandbox, but I'm not sure if we'd need that yet given that we can already have multiple in the Code Sandbox organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants