-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary stuff #1
Comments
Note that the packages will need to be updated to the right scope. I'd do it myself, but I have limited internet/computer access ATM. |
Should we archive this repository in favor of https://codesandbox.io/s/react-testing-library-help-uztri? It's a fork of your sandbox, which I believe was forked from this repository. |
Codesandbox has a variety of issues running tests, can we keep this repo and pull in any relevant changes from over there? |
You can still export a Code Sandbox as a zip or GitHub repository if you have issues with that. I think collaborating on Code Sandbox is easier if we don't need to enforce code reviews, we already have an organization that lets us edit each others templates. |
Maybe we could use the node template instead of the react template. That would effectively allow us to do everything. I use the node template for this repo: https://codesandbox.io/s/github/kentcdodds/testing-node-apps |
I imagine the in-browser Jest stuff (which should be getting updated soon) would run much faster, as Code Sandbox has to wait for the whole Docker container to boot before Node/Jest can start. I still think it would be a good idea to use containers for things like native testing library and puppeteer that require Node though. |
Yes, it is quite a bit slower. Maybe we could do what we do in https://github.com/kentcdodds/react-testing-library-examples Tests that don't work in codesandbox are in a separate directory and the jest config (which only applies when running locally) will run all the tests. |
I think individual sandboxes are easier to use though. It makes the package installation faster and it means that the link can go to a specific file (for example Alternatively we could have a repository where each directory is a sandbox, but I'm not sure if we'd need that yet given that we can already have multiple in the Code Sandbox organization. |
I don't think there's a reason to include kcd-scripts in here.
Let's see if we can slim this repo down to only what's necessary.
The text was updated successfully, but these errors were encountered: