fix(within): Add extra type paramater to allow reassigning in TypeScr…

…ipt (#1077) Co-authored-by: eps1lon <silbermann.sebastian@gmail.com>
testing-library · Jan 15, 2022 · 1f143e5 · 1f143e5
1 parent b4ebc80
commit 1f143e5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/types/__tests__/type-tests.ts b/types/__tests__/type-tests.ts
@@ -254,6 +254,12 @@ export async function testWithin() {
 
   await container.findByRole('button', {name: /click me/i})
   container.getByRole<HTMLButtonElement>('button', {name: /click me/i})
+
+  let withinQueries = within(document.body)
+  withinQueries = within(document.body)
+  withinQueries.getByRole<HTMLButtonElement>('button', {name: /click me/i})
+  withinQueries = within(document.body)
+  withinQueries.getByRole<HTMLButtonElement>('button', {name: /click me/i})
 }
 
 /*

diff --git a/types/get-queries-for-element.d.ts b/types/get-queries-for-element.d.ts
@@ -175,7 +175,8 @@ export interface Queries {
   [T: string]: Query
 }
 
-export function getQueriesForElement<T extends Queries = typeof queries>(
-  element: HTMLElement,
-  queriesToBind?: T,
-): BoundFunctions<T>
+export function getQueriesForElement<
+  QueriesToBind extends Queries = typeof queries,
+  // Extra type parameter required for reassignment.
+  T extends QueriesToBind = QueriesToBind,
+>(element: HTMLElement, queriesToBind?: T): BoundFunctions<T>