Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ESLint 8.x #190

Closed
Tracked by #24
MichaelDeBoey opened this issue Sep 4, 2021 · 5 comments · Fixed by #200
Closed
Tracked by #24

Support ESLint 8.x #190

MichaelDeBoey opened this issue Sep 4, 2021 · 5 comments · Fixed by #200
Labels
released

Comments

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Sep 4, 2021 •
edited
Loading

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂
@MichaelDeBoey MichaelDeBoey mentioned this issue Sep 4, 2021
Merged
63 tasks
@benmonro
Copy link
Member

benmonro commented Sep 4, 2021

Hi Michael would welcome a PR on this.

@MichaelDeBoey MichaelDeBoey mentioned this issue Sep 16, 2021
Merged
@nickserv nickserv mentioned this issue Sep 20, 2021
Merged
2 tasks
@KillWolfVlad KillWolfVlad mentioned this issue Oct 11, 2021
Closed
23 tasks
@weyert
Copy link

weyert commented Nov 18, 2021

I think now with Node v10 support removed this PR can be merged?

@jimmy-guzman jimmy-guzman mentioned this issue Nov 19, 2021
Closed
1 task
@G-Rath
Copy link
Collaborator

G-Rath commented Dec 19, 2021

We were already supporting eslint v8, but now we're testing against it in CI to ensure we remain compatible thanks to #237, so this is resolved 🎉

@G-Rath G-Rath closed this as completed Dec 19, 2021
@G-Rath G-Rath reopened this Dec 19, 2021
@G-Rath
Copy link
Collaborator

G-Rath commented Dec 19, 2021

spoke too soon - #237 has our CI testing against multiple versions of ESLint, but doesn't include testing against v8 itself; that's handled by #200.

(We are still compatible with v8)

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add ESLint 8.x tests testing-library/eslint-plugin-jest-dom
4 participants
@weyert @benmonro @G-Rath @MichaelDeBoey