fix(prefer-to-have-style): properly handle index access of style property
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 563 575 +12
Branches 158 165 +7
=========================================
+ Hits 563 575 +12
Continue to review full report at Codecov.
|
|
There's a bit of a inconsistency between when we report for indexed access vs not, but I think that's probably best tackled in another issue/PR - I think we should be warning on any use of |
MichaelDeBoey
approved these changes
May 20, 2022
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Resolves #264
Resolves #256
Why:
Currently the rule errors due to incorrect fixes.
How:
I've adjusted the rule to handle number literals differently.
Checklist: