feat: make @testing-library/dom a peer dependency
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 581 581
Branches 167 167
=========================================
Hits 581 581 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
G-Rath
force-pushed
the
make-peer-dependency
branch
2 times, most recently
from
d5af778
to
615f9cf
Compare
G-Rath
force-pushed
the
make-peer-dependency
branch
from
615f9cf
to
b4126e6
Compare
MichaelDeBoey
approved these changes
Jun 4, 2023
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Makes
@testing-library/doma required peer dependency.Why:
This ensures that the same version of
@testing-library/domthat is being used on projects is used as part of linting, along with allowing us to support more versions, and just overall reduce downstream pain.Also see #238 for prior discussion
How:
By making
@testing-library/doma peer dependency.Checklist:
Resolves #294
Resolves #301