docs(consistent-data-testid): add clarification about rule creation (#…

…248)

* feat: new setting for customizing file name pattern to report

* test: add custom rule tester for testing library

* refactor: use common rule tester config

* refactor(no-dom-import): use createTestingLibraryRule

* feat(detection-helpers): check imports with require

* test(no-dom-import): include test cases for custom module setting

* test(no-dom-import): include test cases for custom module setting

* chore: fix merge

* refactor(no-dom-import): extract detection helpers for import nodes

* test: increase coverage

* refactor: rename setting for filename pattern

* refactor: add new detection option to skip reporting checks

* refactor(consistent-data-testid): use createTestingLibraryRule

* revert: refactor consistent-data-testid

* revert: detection options

* docs(consistent-data-testid): add clarification about rule creation

lib/rules/consistent-data-testid.ts

@@ -1,5 +1,5 @@
 import { getDocsUrl } from '../utils';
-import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
+import { ESLintUtils } from '@typescript-eslint/experimental-utils';
 import { isJSXAttribute, isLiteral } from '../node-utils';
 
 export const RULE_NAME = 'consistent-data-testid';
@@ -13,6 +13,11 @@ type Options = [
 
 const FILENAME_PLACEHOLDER = '{fileName}';
 
+/**
+ * This rule is not created with `createTestingLibraryRule` since:
+ * - it doesn't need any detection helper
+ * - it doesn't apply to testing files but component files
+ */
 export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
   name: RULE_NAME,
   meta: {
@@ -89,7 +94,7 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
     }
 
     return {
-      [`JSXIdentifier`]: (node: TSESTree.JSXIdentifier) => {
+      JSXIdentifier: (node) => {
         if (
           !isJSXAttribute(node.parent) ||
           !isLiteral(node.parent.value) ||