Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-debugging-utils): enable all methods #663

Merged
merged 1 commit into from
Oct 3, 2022
Merged

feat(no-debugging-utils): enable all methods #663

merged 1 commit into from
Oct 3, 2022

Conversation

skovy
Copy link
Collaborator

@skovy skovy commented Oct 2, 2022 •
edited
Loading

BREAKING CHANGE: enable all debug methods by default for no-debugging-utils

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • Enable all of the debug methods by default in the no-debugging-utils rule

Context

Resolves #621

@skovy skovy changed the title feat: no-debugging-utils enable all methods feat(no-debugging-utils): enable all methods Oct 2, 2022
Belco90
Belco90 requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the options for all the valid/invalid tests manually enabling to report certain debugging methods? They are enabled by default so we don't need to set them explicitly.

@skovy
feat: no-debugging-utils enable all methods
12a5102 
BREAKING CHANGE: enable all debug methods by default for no-debugging-utils
@skovy
Copy link
Collaborator Author

skovy commented Oct 3, 2022

Ah, yea! I think I removed all of the ones that weren't explicitly part of the test. Let me know if I missed any

@Belco90 Belco90 merged commit 2960551 into testing-library:alpha Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

🎉 This PR is included in version 6.0.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey added v6 Next major v6 BREAKING CHANGE This change will require a major version bump labels Oct 4, 2022
@MichaelDeBoey MichaelDeBoey linked an issue Oct 4, 2022 that may be closed by this pull request
Enable reporting all methods by default in no-debugging-utils #621
Closed
MichaelDeBoey pushed a commit that referenced this pull request Oct 4, 2022
@skovy @MichaelDeBoey
feat(no-debugging-utils): enable all debug methods in all configs by …
e394ce0 
…default (#663)

BREAKING CHANGE: `no-debugging-utils` now enables all debug methods in all configs by default
@WontonSam WontonSam mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump hacktoberfest-accepted released on @alpha v6 Next major v6
Projects
No open projects
eslint-plugin-testing-library v6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable reporting all methods by default in no-debugging-utils
3 participants
@skovy @Belco90 @MichaelDeBoey