Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old async utils from the entire plugin #681

Closed
Belco90 opened this issue Oct 21, 2022 · 2 comments · Fixed by #706
Closed

Remove old async utils from the entire plugin #681

Belco90 opened this issue Oct 21, 2022 · 2 comments · Fixed by #706
Assignees
@Belco90
Labels
released on @alpha released v6 Next major v6

Comments

@Belco90
Copy link
Member

Belco90 commented Oct 21, 2022

Relates to #627

Since wait, waitForElement and waitForDomChange have been removed from latest Testing Library versions, we need to do a general clean-up to remove checks for them in the plugin.

For example, the prefer-find-by rule is still looking for wait and waitForElement usages. They must be removed, which would simplify the rule, and tests.

The same could apply to other rules, and also documentation.
@Belco90 Belco90 mentioned this issue Oct 21, 2022
Merged
3 tasks
@Belco90 Belco90 mentioned this issue Dec 23, 2022
Merged
1 task
@Belco90 Belco90 self-assigned this Jan 10, 2023
@Belco90 Belco90 linked a pull request Jan 10, 2023 that will close this issue
refactor: remove remaining support for old async utils #706
Merged
1 task
@Belco90 Belco90 closed this as completed Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

🎉 This issue has been resolved in version 6.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Belco90 Belco90

Labels
released on @alpha released v6 Next major v6
Projects
No open projects
eslint-plugin-testing-library v6
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove remaining support for old async utils testing-library/eslint-plugin-testing-library
1 participant
@Belco90