Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace use of deprecated methods #925

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 14, 2024

Checks

Changes

  • introduced compat utilities that enable support for ESLint v9
  • replaced usages of context functions that were removed in v9 in favor of compat utils

Context

Resolves #924
Resolves #899

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (93a6ab9) to head (88ecc28).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   96.23%   96.31%   +0.07%     
==========================================
  Files          44       45       +1     
  Lines        2419     2470      +51     
  Branches     1000     1023      +23     
==========================================
+ Hits         2328     2379      +51     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath changed the title feat: support ESLint v9 fix: replace use of deprecated methods Aug 14, 2024
@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 14, 2024

#926 proves that this works with ESLint v7, v8, and v9 so I think this should be safe to merge as-is and then we'll be one step closer to supporting ESLint v9 officially

(the CI failure is just a flakey timeout - it should pass if rerun)

@G-Rath
Copy link
Contributor Author

G-Rath commented Sep 12, 2024

@Belco90 @MichaelDeBoey would it be possible to get this and my follow-up PRs progressed, given that they can be released in a minor version?

@Belco90
Copy link
Member

Belco90 commented Oct 14, 2024

Thanks for your contribution, and sorry for the inactivity. I'll try to get this merged during the week.

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 15, 2024

@Belco90 no worries, let me know if there's anything I can do to help - just in case you've not seen it, I've got a few pull requests open which include ones that ultimately lead to allowing ESLint v9 which are chained off of each other.

In order they are:

I should be able to have them rebased within minutes of you landing the prior ones unless I'm sleep, but I can also do a single big PR if you're prefer.

Let me know what works best for you, and also if you have questions or want something done differently

@Belco90
Copy link
Member

Belco90 commented Oct 17, 2024

@G-Rath Amazing, thank you so much! I'm going to merge some other chore PRs first (like your editorconfig PR), then we can rebase this one and start reviewing in the order you mentioned.

Belco90
Belco90 previously approved these changes Oct 17, 2024
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll wait until it's rebased to merge it (hopefully the failing test gets fixed). Thanks again!

lib/utils/compat.ts Show resolved Hide resolved
@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 17, 2024

@Belco90 this is good to go now!

MichaelDeBoey
MichaelDeBoey previously approved these changes Oct 17, 2024
@Belco90 Belco90 added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@Belco90
Copy link
Member

Belco90 commented Oct 17, 2024

@G-Rath Ah sorry, this must be reformatted after I merged the prettier v3 upgrade.

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 17, 2024

@Belco90 done 🙂

@Belco90 Belco90 disabled auto-merge October 17, 2024 22:29
@Belco90 Belco90 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into testing-library:main with commit 8dbcee0 Oct 17, 2024
37 checks passed
@G-Rath G-Rath deleted the support-eslint-v9 branch October 17, 2024 22:34
Copy link

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint v9 - context.getScope is not a function - API change Prepare the rules for ESLint v9
3 participants