-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace use of deprecated methods #925
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 96.23% 96.31% +0.07%
==========================================
Files 44 45 +1
Lines 2419 2470 +51
Branches 1000 1023 +23
==========================================
+ Hits 2328 2379 +51
Misses 91 91 ☔ View full report in Codecov by Sentry. |
#926 proves that this works with ESLint v7, v8, and v9 so I think this should be safe to merge as-is and then we'll be one step closer to supporting ESLint v9 officially (the CI failure is just a flakey timeout - it should pass if rerun) |
@Belco90 @MichaelDeBoey would it be possible to get this and my follow-up PRs progressed, given that they can be released in a minor version? |
Thanks for your contribution, and sorry for the inactivity. I'll try to get this merged during the week. |
@Belco90 no worries, let me know if there's anything I can do to help - just in case you've not seen it, I've got a few pull requests open which include ones that ultimately lead to allowing ESLint v9 which are chained off of each other. In order they are:
I should be able to have them rebased within minutes of you landing the prior ones unless I'm sleep, but I can also do a single big PR if you're prefer. Let me know what works best for you, and also if you have questions or want something done differently |
@G-Rath Amazing, thank you so much! I'm going to merge some other chore PRs first (like your editorconfig PR), then we can rebase this one and start reviewing in the order you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll wait until it's rebased to merge it (hopefully the failing test gets fixed). Thanks again!
df12d17
to
bceceb6
Compare
@Belco90 this is good to go now! |
@G-Rath Ah sorry, this must be reformatted after I merged the prettier v3 upgrade. |
bceceb6
to
03fe5ea
Compare
03fe5ea
to
88ecc28
Compare
@Belco90 done 🙂 |
🎉 This PR is included in version 6.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
context
functions that were removed in v9 in favor of compat utilsContext
Resolves #924
Resolves #899