-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adds expected text for toContainHTML checks that fail (#299) #318
Conversation
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 534 534
Branches 197 197
=========================================
Hits 534 534
Continue to review full report at Codecov.
|
Can you add a regression test for this please? |
@nickmccurdy Definitely. Can you point me where I can find a similar test added? Do not know what a regression test is. EDIT: Figured out what you mean. Although I'm having trouble asserting the return value of a matcher. I think this is not possible on |
@nickmccurdy added the regression tests |
🎉 This PR is included in version 5.11.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
No expected message when tests fail when
toContainHTML
matcher is usedWhy:
Fixes #299
How:
Added an expected block with
htmlText
as the expected string with 'Expected' colour usingutils.EXPECTED_COLOR
Checklist: