-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check equality in toHaveDisplayValue (fix #290) #319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 533 534 +1
Branches 194 197 +3
=========================================
+ Hits 533 534 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickmccurdy technically this is a breaking change, although whoever was relying on this can be considered as having been relying on a bug, so I'm not sure.
It seems like the existing behavior is inaccurate according to the documentation (see #290 (comment)). As users are supposed to follow the documented API, I would consider this to be a semver minor/patch bug fix, not a major release. |
🎉 This PR is included in version 5.11.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@all-contributors add @nickmccurdy for docs, code |
@nickmccurdy I've put up a pull request to add @nickmccurdy! 🎉 |
What: Uses an equality check on strings passed to
toHaveDisplayValue
Why: #290
How: Use
this.equals
(equality check) instead ofmatches
(which usesincludes
for substrings)Checklist: