Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert tweaked ramda imports #96

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

mdjastrzebski
Copy link
Collaborator

What:

Tweaking of Ramda imports in #82 has caused issues for some users. This PR is reverting that change.

Why:

User complained that Ramda import from Jest Native is failing with following error:
image

How:

Replace imports from ramda/src/xxx.js with `{ xxx } from 'ramda';

Checklist:

  • Documentation added to the
    docs
  • Typescript definitions updated
  • Tests
  • Ready to be merged

@mdjastrzebski mdjastrzebski added the bug Something isn't working label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #96 (d274753) into main (af5fdb1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #96   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          143       143           
  Branches        44        44           
=========================================
  Hits           143       143           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/to-be-disabled.js 100.00% <ø> (ø)
src/to-be-empty.js 100.00% <ø> (ø)
src/to-contain-element.js 100.00% <ø> (ø)
src/to-have-prop.js 100.00% <ø> (ø)
src/to-have-style.js 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mdjastrzebski mdjastrzebski merged commit 7387349 into main Aug 10, 2022
@mdjastrzebski mdjastrzebski deleted the fix/revert-ramda-import-tweak branch August 10, 2022 12:20
@github-actions
Copy link

🎉 This PR is included in version 4.0.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant