-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cleanup): microtask flushing now supports fake timers #720
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 403aa5c:
|
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 100 100
Branches 16 16
=========================================
Hits 100 100 Continue to review full report at Codecov.
|
5aeb882
to
c4378c6
Compare
c4378c6
to
403aa5c
Compare
🎉 This PR is included in version 10.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@kentcdodds Just stumbled on this - Thanks for fixing this! FYI: I just filed jestjs/jest#10555 to hopefully get jest to provide an official way to find out if fake timers are being used. Just referencing this here so if the API is added there, appropriate changes can be made. |
What: microtask flushing now supports fake timers
Why: So people can use fake timers in their react tests without it causing issues with React's scheduler
How:
Checklist:
- [ ] Documentation added to the docs siteN/A- [ ] TestsN/A (really really hard to reproduce)- [ ] Typescript definitions updatedN/A