#10 - clean up document targets and components #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oieduardorabelo
commented
May 4, 2019
tests/render.spec.js
Outdated
| @@ -61,4 +65,8 @@ describe('render', () => { | |||
| expect(getByText('Hello world!')).toBeInTheDocument() | |||
| expect(getByTestId('custom-target')).toBeInTheDocument() | |||
| }) | |||
|
|
|||
| test('after each test above, document is clean from targets and components', () => { | |||
| expect(document.body.innerHTML).toBe('<div></div>') | |||
There was a problem hiding this comment.
output here is dependent on previous tests,
- before:
<div></div><div></div><div></div><div></div><main data-testid=\"custom-target\"></main>
There was a problem hiding this comment.
I think the body will be entirely empty after this great addition.
There was a problem hiding this comment.
I agree with @EmilTholin. It should be empty
There was a problem hiding this comment.
indeed is happening, as we can see in the failed build on travis:
i bet it was some kind of local jest cache, running with --no-cache seems to have fixed it!
thanks @EmilTholin @benmonro
oieduardorabelo
commented
May 4, 2019
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing discussion from #10