Skip to content

Add explicit "save" option #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smeijer opened this issue Jun 13, 2020 · 2 comments
Closed

Add explicit "save" option #152

smeijer opened this issue Jun 13, 2020 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@smeijer
Copy link
Member

smeijer commented Jun 13, 2020

The save action, should write the state to a github gist.

I just learned that this is how ASTExplorer does it, and it turns out that it works quite amazing.

For example, take the astexplorer instance:

https://astexplorer.net/#/gist/27a4fea62d9c957de06791e6302aa4d1/664d8a3d29d4db7d6ff7e407dc12ec8815ff75d3
       https://gist.github.com/27a4fea62d9c957de06791e6302aa4d1/664d8a3d29d4db7d6ff7e407dc12ec8815ff75d3

The files that we save can be a source.html with the html, an source.js with the query, and an playground.json for future usage.

If the user is authenticated, we will write the state to his own gists collection. If he is not, we will write it to an (bot) account of this project (I've created the user account: testing-playground-com for this purpose).

All gists will be private.

If a playground has an URL that starts with #/gist/, we will load the state from he gist, just as astexplorer does.


Partially Blocked by #151

@smeijer smeijer added the feature New feature or request label Jun 13, 2020
@smeijer smeijer self-assigned this Jun 27, 2020
@smeijer
Copy link
Member Author

smeijer commented Jun 27, 2020

Got a few lambdas working, but the save button requires some changes in component hierarchy. Will continue later.

@smeijer
Copy link
Member Author

smeijer commented Jul 4, 2020

Closed by #232

@smeijer smeijer closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant