Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all orientation PWA #224

Closed
marcosvega91 opened this issue Jun 28, 2020 · 0 comments · Fixed by #295
Closed

Support all orientation PWA #224

marcosvega91 opened this issue Jun 28, 2020 · 0 comments · Fixed by #295
Labels
bug Something isn't working

Comments

@marcosvega91
Copy link
Member

marcosvega91 commented Jun 28, 2020

Bug Report 🐛

I have installed the application on my smartphone and I see that the orientation was landscape

To Reproduce ✔️

When you open the website of testing-playground click on the install button

Expected behavior 🤔

To support both landscape than portrait

Suggested solution 🔦

We need to simple change the site.webmanifest

diff --git a/public/site.webmanifest b/public/site.webmanifest
index 82d6ab4..7feb201 100644
--- a/public/site.webmanifest
+++ b/public/site.webmanifest
@@ -5,7 +5,7 @@
   "theme_color": "#ffffff",
   "background_color": "#ffffff",
   "display": "standalone",
-  "orientation": "landscape",
+  "orientation": "any",
   "start_url": "/",
   "icons": [
     {

Your Environment 💻

  • browser: Chrome
  • os: Samsung Android
@marcosvega91 marcosvega91 added the bug Something isn't working label Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant