Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on Preview pane does not close any menu like playground or settings on develop environment #243

Closed
delca85 opened this issue Jul 5, 2020 · 4 comments · Fixed by #301
Labels
bug Something isn't working

Comments

@delca85
Copy link
Member

delca85 commented Jul 5, 2020

Bug Report 🐛

Like said in title, playing with https://develop.testing-playground.com/ I found out that once a menu from toolbar like playground or settings is opened, clicking on Preview pane does not close it. While if I click on another pane (MarkupEditor, QueryEditor or Result) closes it.

Expected behavior 🤔

I expected that clicking outside the menu but inside Preview would close the menu. I know this is not a severe issue :)

Suggested solution 🔦

Your Environment 💻

  • browser: Chrome
  • os: Mac
@delca85 delca85 added the bug Something isn't working label Jul 5, 2020
@delca85 delca85 changed the title Clicking on Preview pane does not close any menu like playground or settings Clicking on Preview pane does not close any menu like playground or settings on develop environment Jul 5, 2020
@delca85 delca85 changed the title Clicking on Preview pane does not close any menu like playground or settings on develop environment Clicking on Preview pane does not close any menu like playground or settings on develop environment Jul 5, 2020
@smeijer
Copy link
Member

smeijer commented Jul 6, 2020

I'm not sure what exactly causes this. Maybe clicks in an iframe aren't propagated back to the parent document?

Anyway, I don't think it's worth postponing the release for this issue.

@delca85
Copy link
Member Author

delca85 commented Jul 7, 2020

I totally agree!

@aganglada
Copy link
Collaborator

aganglada commented Nov 11, 2020

Related to an issue from reach-ui, we have exactly the same behaviour reach/reach-ui#566

Screenshot 2020-11-11 at 09 55 33

EDIT: Sent a PR to fix it ;) reach/reach-ui#700

@aganglada
Copy link
Collaborator

@smeijer I will keep track of reach/reach-ui#566 to update our version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants